Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end2endtest: check siks are deleted when use TempSIKs #1193

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mariajdab
Copy link
Contributor

For the anonelectionTempSIKsValidate test, at the end of the election the half of the accounts should not have a valid SIK, due they are using temporal SIK, and the other half of accounts should have it.

#1179

@coveralls
Copy link

coveralls commented Nov 15, 2023

Pull Request Test Coverage Report for Build 7034264787

  • 39 of 52 (75.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 61.755%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/end2endtest/helpers.go 4 8 50.0%
cmd/end2endtest/zkweighted.go 35 44 79.55%
Files with Coverage Reduction New Missed Lines %
vochain/state/cache.go 6 56.41%
Totals Coverage Status
Change from base Build 7025917591: 0.1%
Covered Lines: 14768
Relevant Lines: 23914

💛 - Coveralls

@mariajdab mariajdab force-pushed the end2endtest/check-tempSIK-remove branch 3 times, most recently from 05876f5 to e0edd17 Compare November 15, 2023 12:33
Copy link
Contributor

@altergui altergui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i commented just minor details, really nitpicking, so LGTM

… accounts don't have a valid SIK, due they are using temporal SIK
@mariajdab mariajdab force-pushed the end2endtest/check-tempSIK-remove branch from 008e3cd to 4785b03 Compare November 29, 2023 14:47
@mariajdab mariajdab merged commit 46c2a83 into main Nov 30, 2023
20 checks passed
@mariajdab mariajdab deleted the end2endtest/check-tempSIK-remove branch November 30, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants