Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][DOW-119] decouple StreamingConversation from telephony #594

Draft
wants to merge 12 commits into
base: ajay/typed-model-refactor
Choose a base branch
from

Conversation

ajar98
Copy link
Contributor

@ajar98 ajar98 commented Jun 29, 2024

this PR:

  • decouples ActionsWorker from StreamingConversation
  • creates the notion of PipelineFactory and PipelineConfig, to be used with outbound calls / inbound call configs
  • removes coupling of PhoneConversation and StreamingConversation, and can use any AudioPipeline as the underlying audio worker

tests:

  • adds e2e telephony tests
  • e2e actions worker test

fast follow - on action factory - should probably just be a dependency of ActionsWorker? does not need to be a dependency of an agent (indirect)

Copy link

linear bot commented Jun 29, 2024

@ajar98 ajar98 force-pushed the ajay/dow-119-decouple-streamingconversation-from-telephony branch from d2ab1fa to 4a33f01 Compare July 1, 2024 23:58
@ajar98 ajar98 force-pushed the ajay/dow-113-deprecate-output-queue-and-manually-attach-workers-to-each branch from c787ea0 to 84afa9c Compare July 3, 2024 19:15
@ajar98 ajar98 force-pushed the ajay/dow-119-decouple-streamingconversation-from-telephony branch 2 times, most recently from de03ec3 to fc5837a Compare July 5, 2024 22:45
@ajar98 ajar98 changed the base branch from ajay/dow-113-deprecate-output-queue-and-manually-attach-workers-to-each to main July 5, 2024 22:46
@ajar98 ajar98 force-pushed the ajay/dow-119-decouple-streamingconversation-from-telephony branch 3 times, most recently from 5491d04 to 71d0ca3 Compare July 10, 2024 19:30
@ajar98 ajar98 changed the base branch from main to ajay/dow-119-make-terminate-async July 10, 2024 19:49
@ajar98 ajar98 force-pushed the ajay/dow-119-decouple-streamingconversation-from-telephony branch 3 times, most recently from 2ff7c09 to fddd84b Compare July 10, 2024 21:19
@ajar98 ajar98 force-pushed the ajay/dow-119-decouple-streamingconversation-from-telephony branch from 09ad0be to 76ec249 Compare July 12, 2024 22:10
@ajar98 ajar98 changed the base branch from ajay/dow-119-make-terminate-async to ajay/typed-model-refactor July 12, 2024 22:18
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 11, 2024
Copy link

This PR has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this Sep 18, 2024
@ajar98 ajar98 reopened this Oct 2, 2024
@github-actions github-actions bot removed the stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple ActionsWorker from StreamingConversation Decouple telephony from StreamingConversation
1 participant