Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for NFS #382

Closed
wants to merge 1 commit into from
Closed

Add page for NFS #382

wants to merge 1 commit into from

Conversation

llimllib
Copy link

@llimllib llimllib commented Jul 3, 2020

This PR adds an "NFS" section to the documentation website.

I found the wiki page helpful in getting me up and running with void, so I wanted to migrate it to the new documentation site.

I only migrated the client section because I do not trust myself to migrate the server section without messing up some detail; I have verified the commands in the client section.

I also added mdbook-linkcheck as a build dependency to the README

@ericonr
Copy link
Member

ericonr commented Jul 4, 2020

Do you think you could add the server section as well? I can help with verification and ask for verification from other knowledgeable members.

@flexibeast
Copy link
Contributor

@llimllib: Thanks for your contribution!

As per #327, my preference would be to have this information as part of a more general page for "Network filesystems", which could also include content about Samba. (This PR doesn't need to include that content, however; it can be added later.)

Please don't mix unrelated changes in a single PR; the change to the README to mention mdbook-linkcheck shouldn't be included here. i'll make that change in a separate commit later today.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the style guide here: https://docs.voidlinux.org/contributing/void-docs/style-guide.html

To be merged, the PR should also be a single commit, since you're adding a single file. To fix the indentation, you can run vmdfmt locally on your device.

README.md Outdated Show resolved Hide resolved
src/SUMMARY.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
@llimllib
Copy link
Author

llimllib commented Jul 4, 2020

I think I have responded to all feedback, thanks and it should be ready for re-review.

(I'm used to squashing merges when the PR is complete, I apologize for having pushed multiple commits)

@llimllib
Copy link
Author

llimllib commented Jul 4, 2020

I added the information from void-linux/void-runit#16 that allows a computer to reboot once it has a share mounted

@llimllib
Copy link
Author

llimllib commented Jul 5, 2020

More or less totally rewritten since I found netmount, which solves a lot of the problems of mounting shares.

src/SUMMARY.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
src/config/nfs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@flexibeast flexibeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued work on this! Once the requested changes are addressed, we'll be a lot closer to being able to merge.

@llimllib
Copy link
Author

llimllib commented Jul 5, 2020

I believe I made all requested changes.

(Is there any chance you would consider squashing PRs at merge time in this repo instead of requiring a single commit? That would make it easier for us to collaborate, because you could just make these changes and push them instead of us playing telephone, with me editing a section I don't know anything about?)

@flexibeast
Copy link
Contributor

@llimllib: Thanks!

But, sorry, i'm not sure i follow. If you use the --amend option when you git commit, that will keep your changes 'squashed' into a single commit, without needing any further action on your part .... Am i misunderstanding the issue you're facing?

@llimllib
Copy link
Author

llimllib commented Jul 6, 2020

no worries! I know how to squash commits - I'm just wondering if it would be easier to collaborate by not squashing until it's time to merge

src/config/network-filesystems.md Outdated Show resolved Hide resolved
src/config/network-filesystems.md Outdated Show resolved Hide resolved
src/config/network-filesystems.md Outdated Show resolved Hide resolved
src/config/network-filesystems.md Outdated Show resolved Hide resolved
src/config/network-filesystems.md Show resolved Hide resolved
@llimllib
Copy link
Author

I believe I have responded to all of your comments, and that is the limit of the amount of work I'm willing to do on this. Thank you for hopefully landing the doc page, and for the help on irc.

@flexibeast
Copy link
Contributor

@llimllib: Okay, fair enough. Thanks for your work! i'll close this PR, and continue working on the page in #399.

@flexibeast flexibeast closed this Jul 13, 2020
@ericonr
Copy link
Member

ericonr commented Jul 13, 2020

@llimllib thank you for the initial work, and for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants