Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde.md: Add section on dolphin #436

Merged
merged 1 commit into from
Aug 3, 2020
Merged

kde.md: Add section on dolphin #436

merged 1 commit into from
Aug 3, 2020

Conversation

cinerea0
Copy link
Contributor

This commit adds information from the wiki page on dolphin to the handbook page on KDE. The tracking issue (#327) mentions that this material might be good for the KDE section, so I ported it over as best as I could.

ericonr
ericonr reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can link to this PR in @flexibeast's issue, then. Thanks!

src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
@cinerea0 cinerea0 closed this Jul 30, 2020
@cinerea0
Copy link
Contributor Author

Whoops, forgot to commit before pushing.

@cinerea0 cinerea0 reopened this Jul 30, 2020
@ericonr ericonr added the blocked Blocked by some external event, for now label Jul 30, 2020
@ericonr
Copy link
Member

ericonr commented Jul 30, 2020 •
edited
Loading

This is soft-blocked ony your PR.

If it isn't resolved soon, we can merge it here.

@cinerea0
Copy link
Contributor Author

cinerea0 commented Aug 1, 2020 •
edited
Loading

@ericonr After getting some information from Johnnynator in that PR, I believe my most recent commit now contains the most accurate information. We cannot add ffmpegthumbs as a dependency since it isn't. Since the PR will not be accepted, it is no longer blocking.

As a side note, I had some trouble running mdbook-linkcheck on my computer, and it seems Travis is having trouble as well. Is there a problem with the Void version of the package?

@ericonr
Copy link
Member

ericonr commented Aug 3, 2020

Is there a problem with the Void version of the package?

It was hanging, right? I've openened an issue with upstream to investigate!

ericonr
ericonr reviewed Aug 3, 2020
View reviewed changes
src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
src/config/graphical-session/kde.md Outdated Show resolved Hide resolved
@ericonr ericonr removed the blocked Blocked by some external event, for now label Aug 3, 2020
@ericonr
Copy link
Member

ericonr commented Aug 3, 2020

Would you mind changing the commit message to Add instead of Added?

@cinerea0 cinerea0 changed the title kde.md: Added section on dolphin kde.md: Add section on dolphin Aug 3, 2020
@cinerea0
Copy link
Contributor Author

cinerea0 commented Aug 3, 2020

I've made the changes above and changed the commit message for the last push.

@ericonr
Copy link
Member

ericonr commented Aug 3, 2020

Great, thanks!

@ericonr ericonr merged commit c188ecb into void-linux:master Aug 3, 2020
@flexibeast flexibeast mentioned this pull request Aug 3, 2020
Open
87 tasks
@cinerea0 cinerea0 deleted the dolphin branch August 3, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cinerea0 @ericonr