Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation/guides/chroot: improve the fstab section #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-ricci
Copy link
Contributor

@r-ricci r-ricci commented Aug 2, 2022

From mount(8):

rw
Mount the filesystem read-write.

noatime
Do not update inode access times on this filesystem (e.g. for faster access on the news spool to speed up news servers). This works for all inode types (directories too), so it implies nodiratime.

Swap is not a filesytem and it doesn't have inodes, so these options are useless.

Since this is just an example, it's ok if it is opinionated, equal to the defaults or not suitable for all use cases, but it should not be wrong or irrelevant.

@classabbyamp
Copy link
Member

@r-ricci
Copy link
Contributor Author

r-ricci commented Aug 3, 2022

the installer does this: https://github.com/void-linux/void-mklive/blob/master/installer.sh.in#L1042

I think it's better if the examples are aligned to what the installer does, for the other fstab entries too.

However, after reading the mount(8), fstab(5) and swapon(8) man pages and performing a quick search on the web, it turns out that sw is also meaningless (and ignored) on Linux, despite being widely used. It has a meaning on (some?) *BSD systems, where it is more or less equivalent to auto.

So I believe the installer should be changed. Unless specific options are required (e.g.: discard, pri), the last three fields could be dropped entirely. If specifying all the fields is preferred, I think defaults is the most sensible placeholder.

@r-ricci
Copy link
Contributor Author

r-ricci commented Aug 2, 2023

ping

@Duncaen
Copy link
Member

Duncaen commented Aug 3, 2023

fstab entries should be ordered, the current example is already wrong.

- correctly order fstab records
- align examples to what the installer does
- explain how to change mount options
- minor wording and order changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants