-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python3-aiohttp_socks, python3-aiohttp, python3-async-timeout; add dependencies #46383
Conversation
0925822
to
0206a11
Compare
Hmm, all tests pass locally. Some missing dependency for CI? |
42c6f8f
to
80a5244
Compare
80a5244
to
39f6e90
Compare
I suggest dropping all of the new packages added just to support checks. If those checks requiring these packages can be skipped, great; otherwise, just skip all of the checks. |
OK, I've removed these new dependencies:
But python3-aiosignal is required for python3-aiohttp, and depends on python3-frozenlist (not just for tests). Previously tests were passing, now I get this for python3-aiosignal:
Could this have anything to do with the move to Python 3.12? |
39f6e90
to
bb7602a
Compare
I bumped python3-aiohttp to prerelease 3.9.0b1 for compatibility with Python 3.12. Version 3.8.6 or earlier do not compile.
|
bb7602a
to
7046ae6
Compare
Updated. After nuking my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, notwithstanding my objection to the very existence of the frozenlist
Python package.
|
49726eb
to
4208ff2
Compare
4208ff2
to
db33fb5
Compare
Version 3.9 is required for Python 3.12 Requires python3-async-timeout>=4 Depends on python3-aiosignal Disable tests which now depend on proxy.py and re_assert
Use GitHub for distfiles since PyPI package does not include tests
db33fb5
to
39d65c0
Compare
Updated to |
Testing the changes
New package
This new package conforms to the package requirements: YES
New package: python3-aiosignal-1.3.1: needed for python3-aiohttp v3.8+
New package: python3-frozenlist-1.4.0: needed for python3-aiosignal
python3-aiohttp: update to 3.9.0: needed for passing python3-aiohttp_socks tests; 3.9.0 needed for Python 3.12 compatibility
python3-async-timeout: update to 4.0.3: needed for python3-aiohttp v3.8
Removed these packages added only for satisfying tests from the PR:
python3-tiny-proxy-0.2.0: needed for python3-aiohttp_socks tests
python3-httpx-socks-0.7.8: needed for python3-tiny-proxy tests
python3-proxy.py-2.4.3: needed for python3-aiohttp tests
python3-re_assert-1.1.0: needed for python3-aiohttp tests
@the-maldridge would you care to take a look at this since you maintain python3-aiohttp and python3-async-timeout?