Migrate the creation of runit control files from stage 1 script to core-services #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows later customization of the runit control files (
/run/runit/stopit
, et al.) via core-services instead of having to override in/etc/rc.local
. This is an enabler of a solution to lxc/lxc-ci#408, discussed also in #50.This PR will make the following (nonbreaking) change to the startup process: currently the runit control files are created AFTER the dmesg chmod in
1
. Because core services are executed before the dmesg chmod, this means that the runit control files will be created BEFORE the dmesg chmod. Since runit and dmesg are independent, this should not cause any issues. (A separate question is whether we should move the dmesg work into core services, thus making1
just a simple executor of core services.)After this change, folks using lxd or incus containers will be able to create their own lower-priority core service to modify the permissions on the files to enable proper shutdown/reboot of the containers. These core services will survive upgrades to
void-runit
, unlike the current approach in the container script.