Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM]Mistral implementation #190

Merged
merged 23 commits into from
Jan 26, 2025
Merged

Conversation

jcommaret
Copy link
Contributor

This is the Mistral API implementation on Void using Mistral AI official npm package :

@jcommaret
Copy link
Contributor Author

@andrewpareles : updated Mistral to follow you Friday changes

@jcommaret
Copy link
Contributor Author

jcommaret commented Jan 6, 2025

@andrewpareles when do you plan to merge it ?

@andrewpareles
Copy link
Contributor

Thanks for this - I don't love that Mistral doesn't have an abort method, is there any way we could get around this, or maybe we could use openAI-compatible endpoint to build this instead?

@jcommaret
Copy link
Contributor Author

There is few options

  • Ask Mistral to provide an abort method thought the npm package
  • Built it from the openAI-compatible endpoint feature.

Let me try to find a workaround, I'll keep this merge request open.

This could be also a test for the void auto update feature when it's released.

@jcommaret
Copy link
Contributor Author

@andrewpareles : done, waiting for the merge.

@jcommaret
Copy link
Contributor Author

jcommaret commented Jan 10, 2025

Void using Mistral AI with abort method implemented.

I actually used Void to implement and build the abort method 💥

Capture d’écran 2025-01-10 à 23 50 23

@jcommaret
Copy link
Contributor Author

@andrewpareles :this is working with model-selection as well.

@andrewpareles
Copy link
Contributor

Great, will merge it ASAP.

@andrewpareles
Copy link
Contributor

Cleaned this up to go with conventions, a lot of checks were redundant. Lmk what you think.

What's gitignore -> .tool-use doing? Can we remove that?

Copy link
Contributor Author

@jcommaret jcommaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, trying to merge it on model-selection to see it in action, moving on that

@jcommaret
Copy link
Contributor Author

.tool-versions is a file setup with my version manager to setup nodejs version and python version on the project level.

https://asdf-vm.com for more information.

@andrewpareles
Copy link
Contributor

Alright we can add it to gitignore, will merge

@andrewpareles andrewpareles merged commit 55ea8e6 into voideditor:main Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants