(Diff) compare changes for EDS only in XdsClient #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
4 times, most recently
from
321a8f6 to
885d9b0
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
2 times, most recently
from
08d7b8c to
4f555cf
Compare
voidzcy
force-pushed
the
impl/lds_rds_over_ads_in_xds_client
branch
from
dff75a9 to
dba4115
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
ebe4b3e to
3760201
Compare
…CPU cores (grpc#6439) This would cut the amount of per-thread direct buffer allocations by half, especially with light traffic. This will also cut the amount of file descriptors that's created per thread by half. Internal benchmark results (median of 5 runs) doesn't show any significant change: ``` Before (STDEV) After (STDEV) grpc-java-java-multi-qps-integrity_only Actual QPS 711,004 (6,246) 704,372 (6,873) QPS per Client CPU 23,921 (252) 24,188 (252) grpc-java-java-multi-throughput-integrity_only Actual QPS 35,326 (48) 35,294 (29) QPS per Client CPU 3,362 (17) 3,440 (13) grpc-java-java-single-latency-integrity_only Median latency (us) 127 (2.77) 129 (3.13) grpc-java-java-single-throughput-integrity_only Actual QPS 581 (11.60) 590 (7.08) QPS per Client CPU 490 (10.98) 498 (5.63) ```
This reverts commit 316a739.
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
3760201 to
388e977
Compare
In 48929c4 the protobuf lite artifact name changed from protobuf-lite to protobuf-javalite. However, the exclusion in grpc-protobuf was missed in the update, allowing protobuf lite to leak into the classpath. This restores the previous behavior of only having one protobuf implementation on the classpath.
This is a followup of grpc#6425 to further refactor/cleanup. Now that `LookasideChannelLb` does very little thing, it does not need to be a class anymore.
Implement envoy's LDS and RDS protocols in XdsClient. gRPC has a special purpose xDS resolver to instantiate an XdsClient object and add a watcher to initiate xDS communication with management server to retrieve information used in service config, which configures gRPC's load balancing plugin.
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
388e977 to
9de8847
Compare
…ces received in responses, as server is required to always send newly requested resources.
…chers for the same cluster.
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
d673bbc to
5f83d44
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
5f83d44 to
dea0b46
Compare
voidzcy
pushed a commit
that referenced
this pull request
Mar 25, 2020
Data race was detected internally when
ManagedChannelOrphanWrapper.shutdown() was called concurrently:
WARNING: ThreadSanitizer: data race (pid=5009)
Write of size 8 at 0x7fd2f7f37530 by thread T49:
#0 java.lang.ref.Reference.clear()V Reference.java:265
#1 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clearInternal()V ManagedChannelOrphanWrapper.java:118
#2 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clear()V ManagedChannelOrphanWrapper.java:110
#3 io.grpc.internal.ManagedChannelOrphanWrapper.shutdown()Lio/grpc/ManagedChannel; ManagedChannelOrphanWrapper.java:58
(stacktrace redacted)
Previous write of size 8 at 0x7fd2f7f37530 by thread T45 (mutexes: write M267260296638793720, write M267541771615505864, write M267823246592216728, write M267260296898451984, write M267541771875162784, write M267823246851873416):
#0 java.lang.ref.Reference.clear()V Reference.java:265
#1 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clearInternal()V ManagedChannelOrphanWrapper.java:118
#2 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clear()V ManagedChannelOrphanWrapper.java:110
#3 io.grpc.internal.ManagedChannelOrphanWrapper.shutdown()Lio/grpc/ManagedChannel; ManagedChannelOrphanWrapper.java:58
(stacktrace redacted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.