Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KLIFS: Drop remotely unavailable structures from local database #106

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

dominiquesydow
Copy link
Contributor

@dominiquesydow dominiquesydow commented Sep 16, 2021

Description

When using the local module of opencadd.databases.klifs, we still query for KLIFS IDs (structure/ligand/kinase) remotely because those data points are not provided locally in the KLIFS download files.

If the local download contains structures that are not part of the database --- say you have downloaded data from https://klifs.net/ but our package calls https://dev.klifs.net/ --- you currently get a SwaggerMappingError.

We will contact the KLIFS maintainers (#105) and add an try-except clause that will drop all local structures that are not available remotely

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Add try-except clause to opencadd.databases.klifs.local._LocalDatabaseGenerator._add_klifs_ids
  • Add ERROR to logging, so that missing structures are reported and can be checked out

Questions

None

Status

  • Ready to go

@dominiquesydow dominiquesydow linked an issue Sep 16, 2021 that may be closed by this pull request
@dominiquesydow dominiquesydow self-assigned this Sep 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #106 (d8d6a6e) into master (cdd450b) will decrease coverage by 0.14%.
The diff coverage is 18.18%.

@dominiquesydow dominiquesydow merged commit 1f454e8 into master Sep 16, 2021
@dominiquesydow dominiquesydow deleted the more-fixes branch November 8, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different results from different KLIFS APIs
2 participants