KLIFS: Drop remotely unavailable structures from local database #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the local module of
opencadd.databases.klifs
, we still query for KLIFS IDs (structure/ligand/kinase) remotely because those data points are not provided locally in the KLIFS download files.If the local download contains structures that are not part of the database --- say you have downloaded data from https://klifs.net/ but our package calls https://dev.klifs.net/ --- you currently get a
SwaggerMappingError
.We will contact the KLIFS maintainers (#105) and add an try-except clause that will drop all local structures that are not available remotely
Todos
Notable points that this PR has either accomplished or will accomplish.
opencadd.databases.klifs.local._LocalDatabaseGenerator._add_klifs_ids
Questions
None
Status