Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualize_job does not work unless you use cq_editor #23

Closed
giannissc opened this issue Apr 24, 2023 · 4 comments
Closed

visualize_job does not work unless you use cq_editor #23

giannissc opened this issue Apr 24, 2023 · 4 comments

Comments

@giannissc
Copy link
Contributor

I have recently switched from cq_editor to ocp_cad_viewer extension for vs code. Running visualize_job does not work but visualize_job_as_edges does

@voneiden
Copy link
Owner

It may very well be that AIS based rendering requires changes to ocp_cad_viewer like it required for cq-editor ( CadQuery/CQ-editor#317 ). For cq-editor these changes were pretty simple.

@voneiden
Copy link
Owner

We can also research on our end if the edge based visualization could be improved (support different colours and arrows)

@voneiden
Copy link
Owner

Preliminary testing shows that render performance is actually slightly better with 100k random lines using TopoDS_Edge rather than AIS_Line.

It is slightly slower to generate Edges though.

However there doesn't seem to be any easy way of configuring the color of an edge in OpenCASCADE

@voneiden
Copy link
Owner

voneiden commented May 6, 2023

Fixed by #31 - opened #36 for making the visualization more informative in ocp-vscode.

@voneiden voneiden closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants