Handle destruct in function arg #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be very nice for the review if you could split the changes to have one commit with the refactoring and one with the actual fix, if that makes sense for these changes :-) (we might also merge the refactoring part to other Merlin's branches) |
Fragment the various stages of the `node` function to facilitate understanding of its flow and the reuse of parts.
xvw
force-pushed
the
handle-destruct-in-function-arg
branch
from
8fc4729 to
9f38a32
Compare
|
Is it better this way? |
It's much better, thanks ! |
|
I've added two tests that can handle deconstruction cases on single-field records and single-constructor sums (which seem to be the most trivial use cases for destructing in the presence of function parameters). |
goldfirere
reviewed
Apr 10, 2024
| "Foo" | ||
| ], | ||
| "notifications": [] | ||
| } |
There was a problem hiding this comment.
It would also be good to have tests with:
- A type with one constructor where the constructor has fields.
- A type with one constructor where the constructor has an inline record
- A gadt with multiple constructors, but where the types allow only one constructor to be well-typed. (This is harder -- a reach goal.)
There was a problem hiding this comment.
Hi @goldfirere
- Works fine
- As the previous version, it generate
Ctor _,but currently, the way that pattern are printed seems wrong. For(it wastype t = Foo of {..}it producesFoo_. I am currently investigating on thatsedin test mistake from my side. Fixed now) - With GADT it seems working too
xvw
force-pushed
the
handle-destruct-in-function-arg
branch
from
8f25c63 to
86e76b3
Compare
voodoos
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
destructin the presence of a function parameter.There are still some unanswered questions. For example, for the moment, the case
fun (b: bool) ->will generatefun (true | false : bool). However,fun (_ as b: bool) ->will generatefun ((false as b) | (true as b)) ->. Introducing aliases in the first case seems to me 1, non-trivial and tends towards behavior that's hard to specify when patterns are nested.