Only surface discrepancies in single jurisdiction for finalized batch…

…es (#2095) * Only surface discrepancies in single jurisdiction for finalized batches * Update sampled_batch_results instead of using heuristic of non-empty audit result
votingworks · Dec 16, 2024 · 799f08e · 799f08e
1 parent 9c8ef4b
commit 799f08e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/server/api/discrepancies.py b/server/api/discrepancies.py
@@ -76,6 +76,7 @@ def get_batch_comparison_discrepancies_by_jurisdiction(
         .with_entities(Jurisdiction.name, Batch.name)
         .all()
     )
+
     jurisdiction_name_to_id = dict(
         Jurisdiction.query.filter_by(election_id=election.id).with_entities(
             Jurisdiction.name, Jurisdiction.id

diff --git a/server/api/shared.py b/server/api/shared.py
@@ -159,6 +159,7 @@ def sampled_batch_results(
         .filter(Contest.id == contest.id)
         .join(ContestChoice)
         .outerjoin(BatchResultTallySheet)
+        .filter(BatchResultTallySheet.batch_id.isnot(None))
         .outerjoin(
             BatchResult,
             and_(

diff --git a/server/tests/batch_comparison/test_single_jurisdiction_batch_comparison.py b/server/tests/batch_comparison/test_single_jurisdiction_batch_comparison.py
@@ -100,6 +100,12 @@ def test_batch_comparison_single_jurisdiction_discrepancies(
     choice_names = [choice["name"] for choice in contests[0]["choices"]]
     choice_ids = [choice["id"] for choice in contests[0]["choices"]]
 
+    # No discrepancies should show before any batches are audited
+    set_logged_in_user(client, UserType.AUDIT_ADMIN, DEFAULT_AA_EMAIL)
+    rv = client.get(f"/api/election/{election_id}/discrepancy")
+    discrepancies = json.loads(rv.data)
+    assert len(discrepancies) == 0
+
     # Audit batches
     set_logged_in_user(
         client, UserType.JURISDICTION_ADMIN, default_ja_email(election_id)