drop support for versions < 1.15.0 #1596
Conversation
TheMeier
force-pushed
the
drop_lower_1.15
branch
2 times, most recently
from
5d54e95 to
751a315
Compare
TheMeier
force-pushed
the
drop_lower_1.15
branch
4 times, most recently
from
8168e7c to
34e36c8
Compare
| @@ -240,7 +240,7 @@ | |||
| Hash $nginx_upstreams = {}, | |||
| Nginx::UpstreamDefaults $nginx_upstreams_defaults = {}, | |||
| Boolean $purge_passenger_repo = true, | |||
| String[1] $nginx_version = pick(fact('nginx_version'), '1.6.0'), | |||
| String[1] $nginx_version = pick(fact('nginx_version'), '1.16.0'), | |||
There was a problem hiding this comment.
I am wondering if we can not just default to installed?
| String[1] $nginx_version = pick(fact('nginx_version'), '1.16.0'), | |
| String[1] $nginx_version = 'installed', |
Putting an arbitrary (outdated) version does not look good, and if we do a breaking release maybe it is time to improve this?
There was a problem hiding this comment.
Fine with me, I was just trying to change as little as possible
There was a problem hiding this comment.
Because the code does version comparisons all over the place to see if it's compatible. The version comparison with installed wouldn't work.
Note it's also using a fact so the default should most of the time be dynamic.
there is already breaking changes on master, so next releease will be major test have been broken for a while and will be fixed in voxpupuli#1596
I have set #1595 to ready, maybe we can change it with failing tests. I will clean up here afterwards. I was about to also drop epel7, whole Idea was to prepare a new major release and thus drop debian 10, rhel 7, centos 8 as well as add debian 12 |
there is already breaking changes on master, so next releease will be major test have been broken for a while and will be fixed in voxpupuli#1596
No description provided.