Add loginctl_linger_users fact

[jcpunk]

Pull Request (PR) description

Add a fact listing users with linger enabled.

As near as I can tell from the systemd source, root is always able to linger even it not setup explicitly.

This Pull Request (PR) fixes the following issues

[zilchms]

I am willing to let it pass with the tests written the way they are, but i would suggest we find someone with better rspec knowledge to go over it too before we merge

[h0tw1r3]

Generally not in favor of adding facts like this, particularly on widely used modules. A function or resource may be more appropriate.

That said, what's an sample use case?

[jcpunk]

My overall plan is to feed this value back into

systemd::logind_settings:
    KillExcludeUsers:

So my users with linger will have the ability to trivially persist processes.

Pat

[h0tw1r3]

I'm confused, isn't that redundant if touching a /var/lib/systemd/linger/ file is the same as adding to KillExcludeUsers in the logind conf file?

[traylenator]

I'm confused, isn't that redundant if touching a /var/lib/systemd/linger/ file is the same as adding to KillExcludeUsers in the logind conf file?

Maybe a slight difference:

I guess enable linger will stop things being killed that are running in the systemd --user scope however all other user processes would be killed. Better to encourage users to run long lived processes in the correct context if they want them to survive.

I'm kind of worried about this fact as it would be pretty large in our case.

[jcpunk]

If this fact looks to be too much, I can always run it out of one of my private modules. Just figured I'd default to "share with the community".

[h0tw1r3]

I'm kind of worried about this fact as it would be pretty large in our case.

Agree. My basic objection to a fact like this.

[jcpunk]

No worries, I'll close this out and run the fact privately.

[smortex]

No worries, I'll close this out and run the fact privately.

I also have some "private" facts, mostly because they are not related to a specific module and very site-specific or just not needed by the module to operate and only provide filtering help for tools like choria (e.g. freebsd_reboot_required, nginx_vhosts), but with some adjustments they may make sense for other organizations (in fact some are present in multiple control-repos I manage).

I wonder if it would make sense to have a section of the voxpupuli website with such custom facts that are listed with a short descriptions on a page in a similar way we have PQL queries?

[traylenator]

If I was going to do this and am actually thinking about it I would not rely on puppet to maintain that list. I'd set up a path unit and service and sync /var/lib/systemd/linger entries to KillExcludeUsers settings.