More feedback

vpapavas · Feb 7, 2020 · 4c647f8 · 4c647f8
1 parent 93d745d
commit 4c647f8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/MaximumLagFilter.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/MaximumLagFilter.java
@@ -50,7 +50,7 @@ private MaximumLagFilter(
       final OptionalLong maxEndOffset
   ) {
     this.lagByHost = requireNonNull(lagByHost, "lagByHost");
-    this.routingOptions = requireNonNull(routingOptions, "requireNonNull");
+    this.routingOptions = requireNonNull(routingOptions, "routingOptions");
     this.maxEndOffset = requireNonNull(maxEndOffset, "maxEndOffset");
   }
 

diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutor.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutor.java
@@ -974,7 +974,7 @@ private static final class ConfigRoutingOptions implements RoutingOptions {
       this.overrides = overrides;
     }
 
-    private long getLong(String key) {
+    private long getLong(final String key) {
       if (overrides.containsKey(key)) {
         return (Long) overrides.get(key);
       }

diff --git a/ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/LivenessFilterTest.java b/ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/LivenessFilterTest.java
@@ -37,12 +37,10 @@ public class LivenessFilterTest {
   @Mock
   private HeartbeatAgent heartbeatAgent;
 
-  private Optional<HeartbeatAgent> optionalHeartbeatAgent;
   private Map<KsqlHostInfo, HostStatus> allHostsStatus;
   private KsqlHostInfo activeHost;
   private KsqlHostInfo standByHost1;
   private KsqlHostInfo standByHost2;
-  private HostInfo activeHostInfo;
   private LivenessFilter livenessFilter;
 
   private static final HostStatus HOST_ALIVE = new HostStatus(true, 0L);
@@ -51,10 +49,9 @@ public class LivenessFilterTest {
   @Before
   public void setUp() {
     activeHost = new KsqlHostInfo("activeHost", 2345);
-    activeHostInfo = new HostInfo("activeHost", 2345);
     standByHost1 = new KsqlHostInfo("standby1", 1234);
     standByHost2 = new KsqlHostInfo("standby2", 5678);
-    optionalHeartbeatAgent = Optional.of(heartbeatAgent);
+    Optional<HeartbeatAgent> optionalHeartbeatAgent = Optional.of(heartbeatAgent);
     livenessFilter = new LivenessFilter(optionalHeartbeatAgent);
   }