test: remove sleep and add pollinterval

Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929 · Oct 18, 2023 · 2816dbf · 2816dbf
1 parent 30adaff
commit 2816dbf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/pr-checks.yaml b/.github/workflows/pr-checks.yaml
@@ -1,7 +1,9 @@
 name: pr-checks
 
 on:
-  pull_request:
+  push:
+    branches:
+      - package
 
 jobs:
   docs:

diff --git a/pkg/utils/test/framework.go b/pkg/utils/test/framework.go
@@ -190,7 +190,7 @@ func (f Framework) WaitUntilKeplerCondition(name string, t v1alpha1.ConditionTyp
 
 			condition, _ := k8s.FindCondition(k.Status.Conditions, t)
 			return condition.Status == v1alpha1.ConditionTrue, nil
-		})
+		}, PollInterval(1*time.Minute))
 	return &k
 }
 

diff --git a/tests/e2e/kepler_test.go b/tests/e2e/kepler_test.go
@@ -142,7 +142,7 @@ func TestTaint_WithToleration(t *testing.T) {
 	ds := appsv1.DaemonSet{}
 	f.AssertResourceExists(exporter.DaemonSetName, components.Namespace, &ds)
 
-	time.Sleep(2 * time.Minute)
+	// time.Sleep(2 * time.Minute)
 	kepler := f.WaitUntilKeplerCondition("kepler", v1alpha1.Available)
 	assert.EqualValues(t, len(nodes), kepler.Status.NumberAvailable)