Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pytest coverage #217

Open
14 of 22 tasks
purva-thakre opened this issue Nov 8, 2023 · 3 comments
Open
14 of 22 tasks

Missing pytest coverage #217

purva-thakre opened this issue Nov 8, 2023 · 3 comments

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Nov 8, 2023

Pytest coverage is marking some lines as uncovered through tests. Either have pytest ignore these lines or add tests for these lines.

@purva-thakre purva-thakre self-assigned this Nov 8, 2023
@vprusso
Copy link
Owner

vprusso commented Nov 8, 2023

Ideally, these should all be covered. I think writing tests to cover all of these items is probably a mult-issue type of thing, but I would opt to (eventually) have them covered as opposed to ignoring them (as these are actual gaps in the present testing framework).

@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Nov 8, 2023

I think writing tests to cover all of these items is probably a mult-issue type of thing

Option 1: Would you prefer to create an issue for each? Hovering over each item lets me create a separate issue.

Option 2: Or you mean multi PR type of thing instead? We can use this issue to link all the different PRs.

@vprusso
Copy link
Owner

vprusso commented Nov 8, 2023

That's neat that you can create an issue from the list here that you created. Honestly, in that case, I think the consolidated list you have here could just stay as it is. If/when we are able to address the coverage issues for a given test, we can convert the item in question to an issue and close it out. Capturing it all here is great though!

@purva-thakre purva-thakre removed their assignment Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants