Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort +pycodestyle for Ruff #297

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Add isort +pycodestyle for Ruff #297

merged 4 commits into from
Nov 28, 2023

Conversation

purva-thakre
Copy link
Collaborator

Description

Fixes #286

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e73db0) 98.1% compared to head (a02d05f) 98.1%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #297   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         295     295           
  Lines        6926    6919    -7     
  Branches      772     771    -1     
======================================
- Hits         6795    6790    -5     
+ Misses         90      89    -1     
+ Partials       41      40    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks great! My apologies for not fixing those realignment issues that I left in. Approved! 🚀

@purva-thakre purva-thakre changed the title Add isort for Ruff Add isort +pycodestyle for Ruff Nov 28, 2023
@purva-thakre
Copy link
Collaborator Author

Awesome. Looks great! My apologies for not fixing those realignment issues that I left in. Approved! 🚀

No worries! I don't really think it's your fault.

@purva-thakre purva-thakre merged commit 200f3dc into master Nov 28, 2023
3 checks passed
@purva-thakre purva-thakre deleted the ruff_isort branch November 30, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants