Add pydcostyle + pylint in ruff rules

[purva-thakre]

Description

Fixes #286

Todos

Notable points that this PR has either accomplished or will accomplish.

Edit: Removed checklist.

Questions

• Question1

Status

• Ready to go

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (200f3dc) 98.1% compared to head (21a0450) 98.1%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #298   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         295     295           
  Lines        6919    6919           
  Branches      771     771           
======================================
  Hits         6790    6790           
  Misses         89      89           
  Partials       40      40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[purva-thakre]

@vprusso I am choosing to ignore PLR2004 because 2841708 led to a drop in code coverage.

https://docs.astral.sh/ruff/rules/magic-value-comparison/

I think it's fine to ignore this because I personally can't understand the need to define dim = 2 to replace if dim_something < 2 : with if dim_something < dim :

If you would prefer follow this rule, I can create an issue to remove this rule from ignore after #293, #294 and #240 are completed.

[vprusso]

@vprusso I am choosing to ignore PLR2004 because 2841708 led to a drop in code coverage.

https://docs.astral.sh/ruff/rules/magic-value-comparison/

I think it's fine to ignore this because I personally can't understand the need to define dim = 2 to replace if dim_something < 2 : with if dim_something < dim :

If you would prefer follow this rule, I can create an issue to remove this rule from ignore after #293, #294 and #240 are completed.

Right! I was kind of thinking the same thing. I mean, I guess it often does make sense to not have "magic numbers" floating around. However, checking if something is equal to a given value like if X < 0 is flagged seems a bit crazy!

Agreed, and thank you for making that change!

[vprusso]

Went through the changes and LGTM! MWR! 🚀