-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested fix for issue #59 - Serial tool window exception #61
Conversation
Used this commit from another plugin to suggest a fix for this one: antlr/intellij-plugin-v4@097170b Note - untested and Java is not my main language.
Content content = contentFactory.createContent(mainPanel, Bundle.message("toolwindow.serial-monitor.title"), false); | ||
myToolWindowContentMap.put(SERIAL_MONITOR_ID, content); | ||
toolWindow.getContentManager().addContent(content); | ||
toolWindowManager.invokeLater(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it this way and it worked.
toolWindowManager.invokeLater(() -> { | |
ToolWindowManager.getInstance(project).invokeLater(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toolWindowManager.invokeLater(() -> { | ||
toolWindow = ToolWindowManager.getInstance(project).registerToolWindow(TOOL_WINDOW_ID, false, ToolWindowAnchor.BOTTOM, project, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
introduce local variable
toolWindowManager.invokeLater(() -> { | |
toolWindow = ToolWindowManager.getInstance(project).registerToolWindow(TOOL_WINDOW_ID, false, ToolWindowAnchor.BOTTOM, project, true); | |
ToolWindowManager toolWindowManager = ToolWindowManager.getInstance(project); | |
toolWindowManager.invokeLater(() -> { | |
toolWindow = toolWindowManager.registerToolWindow(TOOL_WINDOW_ID, false, ToolWindowAnchor.BOTTOM, project, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to come up with this fix!
Uhm.. Where/how can I change an installed CLion Plugin? I can just find the CLionArduinoPlugin binary File..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you create a zip or jar, you may be able to install it. (I have not tried it.)
https://www.jetbrains.com/help/idea/managing-plugins.html#install_plugin_from_disk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not added 😠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you create a zip or jar, you may be able to install it. (I have not tried it.) https://www.jetbrains.com/help/idea/managing-plugins.html#install_plugin_from_disk
Gives me: Fail to load plugin descriptor from file CLionArduinoPlugin-patch-1.zip
Please merge and deploy this. |
New version of plugin has this issue fixed. JetBrains should have it approved soon, but there is a direct link to this version before approval: https://plugins.jetbrains.com/plugin/11301-arduino-support/versions/stable/305519. Works with CLion up to 2022.2. 2022.3 is broken and it will take some work to get it working with it. |
Used this commit from another plugin to suggest a fix for this one:
antlr/intellij-plugin-v4@097170b
Note - untested and Java is not my main language.