Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-user documentation for new MariaDB service #97

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

TheBigLee
Copy link
Member

This PR will add the end-user documentation for the new MariaDB service.

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not document things we haven't implemented yet.

It results in a bad UX for people who want to test stuff and get frustrated if it doesn't work.

Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing, then LGTM

@TheBigLee TheBigLee requested a review from Kidswiss January 12, 2024 10:22
@TheBigLee TheBigLee requested a review from wejdross January 12, 2024 11:19
@TheBigLee TheBigLee merged commit cf0188f into master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants