Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external admin account #135

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add external admin account #135

merged 3 commits into from
Mar 4, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Mar 4, 2024

Summary

This commit adds an admin account which is intended to be exposed to the user. This enables the user to change the password of the admin user without breaking the internal scripts of the image.

However, there are no safeguards available to prevent the user from changing the password of the internal admin as well.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss changed the title Add additional Admin account to expose to the customer Add external admin account Mar 4, 2024
@Kidswiss Kidswiss added the enhancement New feature or request label Mar 4, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team March 4, 2024 08:14
@Kidswiss
Copy link
Contributor Author

Kidswiss commented Mar 4, 2024

There are also two commits that change the image tags, as Inventage now provides shorter tags as well.

Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kidswiss added 2 commits March 4, 2024 10:13
This commit adds an admin account which is intended to be exposed to the
user. This enables the user to change the password of the admin user
without breaking the internal scripts of the image.
The function returned a different variable than it sets in the values.
@Kidswiss Kidswiss force-pushed the keycloak/internal_admin branch from 73b2e84 to e5349a6 Compare March 4, 2024 09:13
@Kidswiss Kidswiss merged commit 9d2837b into master Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants