Ability to disable billing for selected services #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default mergo doesn't allow merging a non empty value with an empty value. For example if a field is a string "hello" it would not override it, if the to be merged object contains the same field with "". This works well until someone wants to override a true boolean with a false boolean, in which case the merge doesn't happen. By setting `mergo.WithOverwriteWithEmptyValue`, we can force mergo to merge empty values into noni empty values. darccio/mergo#249
With this commit it's possible to disable the billing for selected services. It works by deploying a separate config map containing this information in the `appcat-control` namespace. This config map is then read by the service composition function and removes the billing accordingly. For more detailed information please have a look at the docs in the commit.
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
zugao
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this commit it's possible to disable the billing for selected services.
It works by deploying a separate config map containing this information in the
appcat-controlnamespace. This config map is then read by the service composition function and removes the billing accordingly.For more detailed information please have a look at the docs in the commit.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog