-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SPKS and implement sts resizing #225
Conversation
82a5bcb
to
845bd8d
Compare
8284db8
to
7e17180
Compare
Did we reuse the scripts or they have been just implemented in this PR? I feel like this PR is full of bombs, have you tested it throughly? |
We did reuse them from the vshnredis, but have been adjusted slightly to work with this setup. |
7e17180
to
72f705c
Compare
5c61b48
to
3dc2630
Compare
3dc2630
to
7ce95ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach.
I've added a few comments about it.
Also, it would be great if this was generic for any release, because right now the code exists more or less identical for two spks services and still with the race condtion for the other services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add PrometheusRule as well to check if annotation crossplane.io/paused
is set for longer than 15 minutes, so we don't end up with partially broken resources and catch early issues.
a063a3b
to
70f0798
Compare
This is obsolete, as we use |
bc3a043
to
147e34d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that, just one nitpick. LGTM
147e34d
to
19df6b7
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
19df6b7
to
5d1fa1e
Compare
Summary
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog