Skip to content

Commit

Permalink
Ensure auto-converted CDRs have new preserveUnknownFields default set.
Browse files Browse the repository at this point in the history
Newly applied `apiextensions.k8s.io/v1` set `preserveUnknownFields` to false. If the `apiextensions.k8s.io/v1` manifest was migrated from `apiextensions.k8s.io/v1beta1` `preserveUnknownFields` is set to true. This PR ensures all installations use the same default.
  • Loading branch information
bastjan committed Jun 13, 2024
1 parent 5765292 commit 6d27ec7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ spec:
listKind: SyncConfigList
plural: syncconfigs
singular: syncconfig
preserveUnknownFields: false
scope: Namespaced
versions:
- additionalPrinterColumns:
Expand Down
2 changes: 1 addition & 1 deletion generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
package main

//go:generate go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
//go:generate go run sigs.k8s.io/controller-tools/cmd/controller-gen rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=${CRD_ROOT_DIR}/v1/base crd:crdVersions=v1
//go:generate go run sigs.k8s.io/controller-tools/cmd/controller-gen rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=${CRD_ROOT_DIR}/v1/base crd:crdVersions=v1,deprecatedV1beta1CompatibilityPreserveUnknownFields=false

0 comments on commit 6d27ec7

Please sign in to comment.