feat(acessibility): added aria properties to resolve accessibility is…

…sues pointed out by lighthouse
vtex-apps · Oct 9, 2023 · dfba4e0 · dfba4e0
1 parent a334297
commit dfba4e0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/react/Drawer.tsx b/react/Drawer.tsx
@@ -184,7 +184,7 @@ function Drawer(props: Props) {
       <div
         onClick={openMenu}
         role="presentation"
-        aria-hidden={isMenuOpen ? 'false' : 'true'}
+        aria-hidden={!isMenuOpen ? 'false' : 'true'}
         className={`pa4 pointer ${handles.openIconContainer}`}
       >
         {hasTriggerBlock ? (

diff --git a/react/DrawerCloseButton.tsx b/react/DrawerCloseButton.tsx
@@ -24,6 +24,8 @@ const DrawerCloseButton: React.FC<Props> = ({
   return (
     <button
       className={`${handles.closeIconButton} pa4 pointer bg-transparent transparent bn pointer`}
+      id="closeIcon"
+      aria-label="Close Icon Button"
       onClick={close}
     >
       {text ?? <IconClose size={size} type={type} />}

diff --git a/react/Swipable.tsx b/react/Swipable.tsx
@@ -457,7 +457,6 @@ export default class Swipable extends React.Component<Props> {
   public render() {
     return (
       <div
-        aria-hidden={this.props.enabled ? 'false' : 'true'}
         ref={this.dragContainer}
         style={{
           ...this.props.style,