Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/set up enumNames on schema and add pt/en translations #112

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

natanfernandes
Copy link
Contributor

What problem is this solving?

Add translations for the dropdown options for the props showNavigationArrows and showPaginationDots

How to test it?

  • Switch to this branch and link to workspace
  • Go to https://{workspace}--{account}.myvtex.com/admin/cms/site-editor -> Image List -> Slider Layout
  • Check if the options the Show navigation arrows and Show pagination dots dropdowns are correctly translated

Workspace

Screenshots or example usage:

Captura de Tela 2023-05-23 às 17 09 02

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

@natanfernandes natanfernandes requested review from a team as code owners May 23, 2023 20:19
@natanfernandes natanfernandes removed the request for review from a team May 23, 2023 20:19
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented May 23, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 23, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
GeorgeLimaDev and others added 2 commits June 9, 2023 09:21
Co-authored-by: Camila Vieira Coutinho <[email protected]>
Co-authored-by: Camila Vieira Coutinho <[email protected]>
@iago1501 iago1501 merged commit 0b22a6c into master Aug 21, 2024
6 of 7 checks passed
@iago1501 iago1501 deleted the feat/add-translation-to-dropdown-props-options branch August 21, 2024 14:48
Copy link

vtex-io-ci-cd bot commented Aug 21, 2024

Your PR has been merged! App is being published. 🚀
Version 0.24.5 → 0.24.6

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants