Add touch-action style property #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efremov-av
requested review from
hellofanny,
lariciamota and
vsseixaso
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
iago1501
approved these changes
Aug 8, 2024
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Add touch-action style property to the sliderLayoutContainer component to prevent unexpected scrolling on Y axis when moving finger horizontally
How to test it?
Before this fix, if you scroll the slider horizontally with your finger it may also scroll the page on Y axis when the touch move direction is not straight. Now if you initiate horizontal scrolling it will not scroll the page vertically
URL to test:
https://devalex--dunnesstorespreprod.myvtex.com
Screenshots or example usage:
Before:
https://github.com/user-attachments/assets/001445ff-78c1-4969-b0af-3863f104cf57
After:
https://github.com/user-attachments/assets/b1e991c5-7c7f-4330-80f6-fd7bd1b4e582