Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: brand route on product brand #1115

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

vsseixaso
Copy link
Contributor

What problem is this solving?

The ProductBrand component was returning a brand route with the /b suffix, which should no longer be used. This was providing users with access to a broken brand link. The solution was to remove the incorrect/deprecated suffix.

How to test it?

  1. Access a PDP (example PDP)
  2. Click on the brand displayed for the product (in this case, Pip Studio)
  3. The brand's PLP should load correctly (example PLP)

Screenshots or example usage:

[Before]

Brand link with /b on the PDP
pdp-master

Brand PLP did not load correctly
Screenshot 2024-09-10 at 4 01 28 PM

[After]

Brand link without /b on the PDP
pdp-vsseixaso

Brand PLP loaded correctly
Screenshot 2024-09-10 at 4 05 32 PM

Related to / Depends on

This PR is a fix related to the Ticket on Zendesk.

How does this PR make you feel?

Copy link
Contributor

vtex-io-ci-cd bot commented Sep 10, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vsseixaso vsseixaso self-assigned this Sep 10, 2024
@vsseixaso vsseixaso added the bug Something isn't working label Sep 10, 2024
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsseixaso vsseixaso merged commit f2835e3 into master Sep 11, 2024
5 of 6 checks passed
@vsseixaso vsseixaso deleted the fix/brand-route-on-product-brand branch September 11, 2024 17:13
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 11, 2024

Your PR has been merged! App is being published. 🚀
Version 3.175.0 → 3.175.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants