Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preload image pdp #1123

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gabridevs
Copy link

What problem is this solving?

This change improves the loading performance of product images by preloading the main product image via a tag in the ProductImage component. It ensures that the primary image is fetched earlier in the page load process, reducing time-to-visual-complete and enhancing user experience, particularly on slower connections.

How to test it?

You can test this by checking the network activity in the browser’s developer tools. The main product image should be listed as a preloaded resource, and the page should render the image faster compared to the previous behavior.

Workspace

Screenshots or example usage:

Screenshot 2024-10-17 alle 16 58 09

Copy link
Contributor

vtex-io-ci-cd bot commented Oct 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@gabridevs
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

* [ ]  Patch (backwards-compatible bug fixes)

* [x]  Minor (backwards-compatible functionality)

* [ ]  Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

* [ ]  No thanks, I would rather do it manually 😞

@gabridevs
Copy link
Author

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

* [ ]  There's nothing new to document 🤔

* [ ]  I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

* [x]  I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant