Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isDisposable to address graphql #628

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

lucvysk
Copy link
Contributor

@lucvysk lucvysk commented Aug 31, 2022

What problem is this solving?

When adding an address with isDisposable: true the address is saved in MasterData anyways.v It was described here: #541

How to test it?

curl --location --request PUT 'https://isdisposable--modeloramamx.vtexcommercestable.com.br/api/checkout/pub/orders' \
--header 'VtexIdclientAutCookie: ' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--data-raw '{
  "items": [
    {
      "id": "49",
      "quantity": 1,
      "seller": "modeloramamxnorte"
    },
    {
      "id": "58",
      "quantity": 1,
      "seller": "1",
      "price": 0
    }
  ],
  "clientProfileData": {
    "email": "[email protected]",
    "firstName": "Lucas",
    "lastName": "v",
    "document": "00000",
    "documentType": "cedulamx",
    "phone": "+529999",
  },
  "shippingData": {
    "address": {
      "addressType": "residential",
      "receiverName": "Lucas v",
      "isDisposable": true,
      "postalCode": "03300",
      "city": "Ciudad de México",
      "state": "Ciudad de México",
      "country": "MEX",
      "street": "Avenida Presidentes",
      "number": "999",
      "neighborhood": "Portales Norte",
      "complement": "",
      "reference": null,
      "geoCoordinates": [-99.14809799999999, 19.3678483]
    },
    "logisticsInfo": [
      {
        "itemIndex": 0,
        "selectedSla": "Normal",
        "price": 0
      },
      {
        "itemIndex": 1,
        "selectedSla": "Normal",
        "price": 0
      }
    ]
  },
  "marketingData": {
    "coupon": "wp-2022"
  },
  "selectableGifts": [
    {
      "id": "f0bfe8eb-f578-47b1-bc5c-e9990d4d088f",
      "availableQuantity": 1,
      "availableGifts": [
        {
          "id": "58",
          "requestIndex": null,
          "quantity": 1,
          "seller": "1"
        }
      ]
    }
  ],
  "paymentData": {
    "payments": [
      {
        "paymentSystem": "201",
        "referenceValue": 0,
        "value": 0,
        "installments": 1
      }
    ]
  }
}'

Workspace

Related to / Depends on

#541

How does this PR make you feel? 🔗

ss

@lucvysk lucvysk requested a review from a team as a code owner August 31, 2022 15:04
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 31, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 31, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@lucvysk lucvysk requested review from filipewl, hellofanny and icazevedo and removed request for a team August 31, 2022 15:04
@danzanzini danzanzini merged commit cc2fc77 into master Aug 31, 2022
@danzanzini danzanzini deleted the feature/add-isDisposable branch August 31, 2022 19:15
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 31, 2022

Your PR has been merged! App is being published. 🚀
Version 2.155.32 → 2.155.33

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants