Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-dom): remove unnecessary judgment #12768

Closed
wants to merge 1 commit into from

Conversation

zhangenming
Copy link
Contributor

No description provided.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (-1 B) 38 kB (-2 B) 34.2 kB (+14 B)
vue.global.prod.js 158 kB (-1 B) 57.8 kB (-1 B) 51.5 kB (+75 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12768

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12768

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12768

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12768

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12768

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12768

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12768

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12768

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12768

vue

npm i https://pkg.pr.new/vue@12768

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12768

commit: ee2c933

@@ -25,7 +25,7 @@ export const vShow: ObjectDirective<VShowElement> & { name?: 'show' } = {
}
},
updated(el, { value, oldValue }, { transition }) {
if (!value === !oldValue) return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(!null === !undefined) // true

@jh-leong jh-leong closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants