Skip to content

Commit

Permalink
feat: fragment
Browse files Browse the repository at this point in the history
  • Loading branch information
sxzz committed Nov 25, 2023
1 parent 9b2a6ff commit ac68603
Show file tree
Hide file tree
Showing 12 changed files with 146 additions and 89 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ See the To-do list below or `// TODO` comments in code (`compiler-vapor` and `ru
- [ ] compiler
- [ ] Remove DOM API in codegen
- [ ] Fragment
- [x] multiple root nodes
- [ ] Built-in Components
- [ ] Transition
- [ ] TransitionGroup
Expand Down
141 changes: 95 additions & 46 deletions packages/compiler-vapor/__tests__/__snapshots__/compile.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -5,86 +5,106 @@ exports[`comile > bindings 1`] = `
import { template, children, insert, setText } from 'vue/vapor';
const t0 = template(\`<div>count is <!>.</div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
1: [n2],
} = children(n0);
const n1 = document.createTextNode(count.value);
insert(n1, n0, n2);
0: [
n1,
{
1: [n3],
},
],
} = children(root);
const n2 = document.createTextNode(count.value);
insert(n2, n1, n3);
watchEffect(() => {
setText(n1, undefined, count.value);
setText(n2, undefined, count.value);
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-bind > simple expression 1`] = `
"import { watchEffect } from 'vue';
import { template, setAttr } from 'vue/vapor';
import { template, children, setAttr } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setAttr(n0, 'id', undefined, id.value);
setAttr(n1, 'id', undefined, id.value);
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-html > no expression 1`] = `
"import { watchEffect } from 'vue';
import { template, setHtml } from 'vue/vapor';
import { template, children, setHtml } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setHtml(n0, undefined, '');
setHtml(n1, undefined, '');
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-html > simple expression 1`] = `
"import { watchEffect } from 'vue';
import { template, setHtml } from 'vue/vapor';
import { template, children, setHtml } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setHtml(n0, undefined, code.value);
setHtml(n1, undefined, code.value);
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-on > simple expression 1`] = `
"import { watchEffect } from 'vue';
import { template, on } from 'vue/vapor';
import { template, children, on } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
on(n0, 'click', handleClick);
on(n1, 'click', handleClick);
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-once > as root node 1`] = `
"import { watchEffect } from 'vue';
import { template, setAttr } from 'vue/vapor';
import { template, children, setAttr } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setAttr(n0, 'id', undefined, foo);
setAttr(n1, 'id', undefined, foo);
});
return n0;
return root;
}
"
`;
Expand All @@ -93,53 +113,82 @@ exports[`comile > directives > v-once > basic 1`] = `
"import { template, children, insert, setText, setAttr } from 'vue/vapor';
const t0 = template(\`<div> <span></span></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
1: [n2],
} = children(n0);
const n1 = document.createTextNode(msg.value);
insert(n1, n0, 0 /* InsertPosition.FIRST */);
setText(n1, undefined, msg.value);
setAttr(n2, 'class', undefined, clz.value);
return n0;
0: [
n1,
{
1: [n3],
},
],
} = children(root);
const n2 = document.createTextNode(msg.value);
insert(n2, n1, 0 /* InsertPosition.FIRST */);
setText(n2, undefined, msg.value);
setAttr(n3, 'class', undefined, clz.value);
return root;
}
"
`;

exports[`comile > directives > v-text > no expression 1`] = `
"import { watchEffect } from 'vue';
import { template, setText } from 'vue/vapor';
import { template, children, setText } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setText(n0, undefined, '');
setText(n1, undefined, '');
});
return n0;
return root;
}
"
`;

exports[`comile > directives > v-text > simple expression 1`] = `
"import { watchEffect } from 'vue';
import { template, setText } from 'vue/vapor';
import { template, children, setText } from 'vue/vapor';
const t0 = template(\`<div></div>\`);
export function render() {
const n0 = t0();
const root = t0();
const {
0: [n1],
} = children(root);
watchEffect(() => {
setText(n0, undefined, str.value);
setText(n1, undefined, str.value);
});
return n0;
return root;
}
"
`;

exports[`comile > fragment 1`] = `
"import { template, children } from 'vue/vapor';
const t0 = template(\`<p></p><span></span><div></div>\`);
export function render() {
const root = t0();
const {
0: [n1],
1: [n2],
2: [n3],
} = children(root);
return root;
}
"
`;

exports[`comile > static template 1`] = `
"import { template } from 'vue/vapor';
"import { template, children } from 'vue/vapor';
const t0 = template(\`<div><p>hello</p><input><span></span></div>\`);
export function render() {
const n0 = t0();
return n0;
const root = t0();
const {
0: [n1],
} = children(root);
return root;
}
"
`;
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`fixtures 1`] = `
"import { defineComponent as _defineComponent } from 'vue'
import { watchEffect } from 'vue'
import { template, children, insert, setText, on, setHtml } from 'vue/vapor'
const t0 = template(\`<div><h1 id=\\"title\\">Counter</h1><p>Count: </p><p>Double: </p><button>Increment</button><div></div><input type=\\"text\\"><p>once: </p><p>{{ count }}</p></div>\`)
const t0 = template(\`<h1 id=\\"title\\">Counter</h1><p>Count: </p><p>Double: </p><button>Increment</button><div></div><input type=\\"text\\"><p>once: </p><p>{{ count }}</p>\`)
import { ref, computed } from 'vue'
const html = '<b>HTML</b>'
Expand All @@ -19,28 +19,28 @@ const increment = () => count.value++
return (() => {
const n0 = t0()
const { 1: [n1], 2: [n3], 3: [n5], 4: [n6], 6: [n7],} = children(n0)
const n2 = document.createTextNode(count.value)
insert(n2, n1)
const n4 = document.createTextNode(double.value)
insert(n4, n3)
const n8 = document.createTextNode(count.value)
insert(n8, n7)
setText(n8, undefined, count.value)
const root = t0()
const { 0: [n1], 1: [n2], 2: [n4], 3: [n6], 4: [n7], 5: [n8], 6: [n9], 7: [n11],} = children(root)
const n3 = document.createTextNode(count.value)
insert(n3, n2)
const n5 = document.createTextNode(double.value)
insert(n5, n4)
const n10 = document.createTextNode(count.value)
insert(n10, n9)
setText(n10, undefined, count.value)
watchEffect(() => {
setText(n2, undefined, count.value)
setText(n3, undefined, count.value)
})
watchEffect(() => {
setText(n4, undefined, double.value)
setText(n5, undefined, double.value)
})
watchEffect(() => {
on(n5, \\"click\\", increment)
on(n6, \\"click\\", increment)
})
watchEffect(() => {
setHtml(n6, undefined, html)
setHtml(n7, undefined, html)
})
return n0
return root
})();
}
Expand Down
5 changes: 5 additions & 0 deletions packages/compiler-vapor/__tests__/compile.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ describe('comile', () => {
expect(code).matchSnapshot()
})

test('fragment', async () => {
const code = await compile(`<p/><span/><div/>`)
expect(code).matchSnapshot()
})

test('bindings', async () => {
const code = await compile(`<div>count is {{ count }}.</div>`, {
bindingMetadata: {
Expand Down
18 changes: 8 additions & 10 deletions packages/compiler-vapor/__tests__/fixtures/counter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,12 @@ const html = '<b>HTML</b>'
</script>

<template>
<div>
<h1 id="title">Counter</h1>
<p>Count: {{ count }}</p>
<p>Double: {{ double }}</p>
<button @click="increment">Increment</button>
<div v-html="html" />
<input type="text" />
<p v-once>once: {{ count }}</p>
<p v-pre>{{ count }}</p>
</div>
<h1 id="title">Counter</h1>
<p>Count: {{ count }}</p>
<p>Double: {{ double }}</p>
<button @click="increment">Increment</button>
<div v-html="html" />
<input type="text" />
<p v-once>once: {{ count }}</p>
<p v-pre>{{ count }}</p>
</template>
15 changes: 5 additions & 10 deletions packages/compiler-vapor/src/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,14 @@ export function generate(
vaporHelpers.add('template')
}

for (const [, { id, children }] of Object.entries(ir.children)) {
code += `const n${id} = t0()\n`

if (Object.keys(children).length) {
code += `const {${genChildren(children)}} = children(n${id})\n`
vaporHelpers.add('children')
}
{
code += `const root = t0()\n`
code += `const {${genChildren(ir.children.children)}} = children(root)\n`
vaporHelpers.add('children')

for (const operation of ir.operation) {
code += genOperation(operation)
}

for (const [_expr, operations] of Object.entries(ir.effect)) {
// TODO don't use watchEffect from vue/core, implement `effect` function in runtime-vapor package
let scope = `watchEffect(() => {\n`
Expand All @@ -49,9 +45,8 @@ export function generate(
scope += '})\n'
code += scope
}

// TODO multiple-template
code += `return n${id}\n`
code += `return root\n`
}

if (vaporHelpers.size)
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-vapor/src/ir.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface IRNode {
export interface RootIRNode extends IRNode {
type: IRNodeTypes.ROOT
template: Array<TemplateGeneratorIRNode>
children: DynamicChildren
children: DynamicChild
// TODO multi-expression effect
effect: Record<string /* expr */, OperationNode[]>
operation: OperationNode[]
Expand Down
9 changes: 7 additions & 2 deletions packages/compiler-vapor/src/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,22 @@ export function transform(
type: IRNodeTypes.ROOT,
loc: root.loc,
template: [],
children: {},
children: {} as any,
effect: Object.create(null),
operation: [],
helpers: new Set([]),
vaporHelpers: new Set([]),
}
const ctx = createRootContext(ir, root, options)
const rootId = ctx.getElementId()

// TODO: transform presets, see packages/compiler-core/src/transforms
transformChildren(ctx, true)
ir.children = ctx.children
ir.children = {
store: true,
id: rootId,
children: ctx.children,
}

return ir
}
Expand Down
Loading

0 comments on commit ac68603

Please sign in to comment.