perf(VOverlay): only add resize listener when overlay is open

closes #18372
vuetifyjs · Dec 2, 2023 · ca2174c · ca2174c
1 parent b52e935
commit ca2174c
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/packages/vuetify/src/components/VOverlay/locationStrategies.ts b/packages/vuetify/src/components/VOverlay/locationStrategies.ts
@@ -83,22 +83,18 @@ export function useLocationStrategies (
     useToggleScope(() => !!(data.isActive.value && props.locationStrategy), reset => {
       watch(() => props.locationStrategy, reset)
       onScopeDispose(() => {
+        window.removeEventListener('resize', onResize)
         updateLocation.value = undefined
       })
 
+      window.addEventListener('resize', onResize, { passive: true })
+
       if (typeof props.locationStrategy === 'function') {
         updateLocation.value = props.locationStrategy(data, props, contentStyles)?.updateLocation
       } else {
         updateLocation.value = locationStrategies[props.locationStrategy](data, props, contentStyles)?.updateLocation
       }
     })
-
-    window.addEventListener('resize', onResize, { passive: true })
-
-    onScopeDispose(() => {
-      window.removeEventListener('resize', onResize)
-      updateLocation.value = undefined
-    })
   }
 
   function onResize (e: Event) {