-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VListGroup): support return-object #20595
base: master
Are you sure you want to change the base?
Conversation
@KaelWD @johnleider Could you briefly check the browser.spec.tsx file being migrated? |
I think we need to require a primitive item-value anyway to fix return-object matching performance and #19447. |
primitive item-value is cleaner but atm it requires refactoring |
@KaelWD If pass primitive item-value, it ends up with three props to be able to get the real "item-key" as well as return the object to v-model:opened, so I came up with a new more straightforward prop "rawId" |
The merge-base changed after approval.
Description
fixes #20477
Convert
VListGroup.spec.cy.tsx
toVListGroup.spec.browser.tsx
Markup: