-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VInfiniteScroll): add reset method #20637
base: dev
Are you sure you want to change the base?
Conversation
d3e1c87
to
88067eb
Compare
packages/vuetify/src/components/VInfiniteScroll/VInfiniteScroll.tsx
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VInfiniteScroll/VInfiniteScroll.tsx
Outdated
Show resolved
Hide resolved
7730f54
to
6af686d
Compare
I also encountered this problem when I tried to combine VInfiniteScroll and paging |
@J-Sek Any chance this PR will get merged? Solution seems to work well and the method seems to be highly-requested by the community. I currently encounter this issue as well. If I can do anything to expedite the process, let me know. |
if (props.mode !== 'manual') { | ||
nextTick(() => { | ||
window.requestAnimationFrame(() => { | ||
window.requestAnimationFrame(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I could see at least one example where it would fail when implementation omits these rAF wrappers. Or maybe you could tell me if these were copied from done "just in case" or for some actual reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my end it also worked fine with and without, I just copied them from above because of #17475
23c143f
to
fec2cab
Compare
Nevermind, linting fails for spec files. |
Description
When the VInfiniteScroll reaches the 'empty' state, it is not possible to get out of it without doing any tricks such as caching the
done
method.Many users are using this component to paginate search results, and when a specific search returns zero items, the component will be stuck in the
empty
statecloses #20308
closes #19935
Markup: