Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withRecursive method #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adayNU
Copy link

@adayNU adayNU commented Feb 4, 2022

Type of PR:

  • Bugfix
  • Feature
  • Refactor
  • Code style update
  • Build-related changes
  • Test
  • Documentation
  • Other, please describe:

Breaking changes:

  • No
  • Yes

Details

This adds a withRecursive method that makes it easy to recursively eagerly load parent/child relationships within the same model. Doing so with withAllRecursive is prohibitively expensive for large depth values.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #117 (8c7c981) into master (6c23c18) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1251      1257    +6     
  Branches       185       186    +1     
=========================================
+ Hits          1251      1257    +6     
Impacted Files Coverage Δ
src/query/Query.ts 100.00% <100.00%> (ø)
src/repository/Repository.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c23c18...8c7c981. Read the comment docs.

@adayNU
Copy link
Author

adayNU commented Feb 15, 2022

Bump?

@cuebit
Copy link
Member

cuebit commented Mar 14, 2022

Do you have capacity to add documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants