Skip to content

Commit

Permalink
🗑️ Remove a few TODOs.
Browse files Browse the repository at this point in the history
  • Loading branch information
rabrowne85 committed Jan 25, 2024
1 parent 12bbba5 commit d1a780a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions config/datum.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
*/

'recorders' => [
// Recorders\UserRequests::class => [
// 'enabled' => env('DATUM_USER_REQUESTS_ENABLED', true),
// Recorders\ExampleRecord::class => [
// 'enabled' => env('YOUR_RECORDER_ENABLED', true),
// 'sample_rate' => env('DATUM_USER_REQUESTS_SAMPLE_RATE', 1),
// 'ignore' => [
// '#^/datum$#', // Datum dashboard...
Expand Down
6 changes: 2 additions & 4 deletions src/Datum.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ protected function ingestWhenOverBufferSize(): void
return;
}

// TODO remove fallback when tagging v1
$buffer = $this->app->make('config')->get('datum.ingest.buffer') ?? 5_000;
$buffer = $this->app->make('config')->get('datum.ingest.buffer');

if (($this->entries->count() + $this->lazy->count()) > $buffer) {
$this->evaluatingBuffer = true;
Expand Down Expand Up @@ -247,8 +246,7 @@ public function ingest(): int
return $entries->count();
}) ?? 0;

// TODO remove fallback when tagging v1
$odds = $this->app->make('config')->get('datum.ingest.trim.lottery') ?? $this->app->make('config')->get('datum.ingest.trim_lottery');
$odds = $this->app->make('config')->get('datum.ingest.trim.lottery');

Lottery::odds(...$odds)
->winner(fn () => $this->rescue(fn () => $ingest->trim(...)))
Expand Down

0 comments on commit d1a780a

Please sign in to comment.