Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting updates for vyper v0.4.0 #8

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

charles-cooper
Copy link
Member

No description provided.

@@ -12,16 +12,15 @@ endif
"Keywords
syn keyword vyperNatspec @title @licence @author @notice @dev @param @return @version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be @license and also @custom:... is missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think those are already handled by the syn match vyperNatspec rule

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I refer to actually: image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unsafe_ math functions are missing and some further builtins like print, _abi_encode, _abi_decode, blobhash, blockhash, isqrt, sqrt, min_value, max_value, epsilon, abs, uint2str, send, selfdestruct, raw_revert, raw_log, create_from_blueprint, create_copy_of, create_minimal_proxy_to or the type immutable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh, it's a redundant rule anyway, they are already all highlighted the same as vyperFunction

syntax/vyper.vim Outdated
@@ -2,7 +2,7 @@
" Language: Vyper (https://github.com/vyperlang/vyper)
" Author: chgue (https://github.com/chgue)
" URL: https://github.com/vyperlang/vim-vyper
" Last Change: 2020-10-10
" Last Change: 2024-06-07
" Filenames: *.vy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have also .vyi here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that's already handled in ftdetect actually

Copy link

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged and adjust later if something is missing.

@charles-cooper charles-cooper merged commit b7aa72e into vyperlang:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants