feat[venom]: common subexpression elimination pass #4241
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class _Expression: | ||
| first_inst : IRInstruction | ||
| opcode: str | ||
| operands : list[IROperand] |
There was a problem hiding this comment.
looks like this can be IROperand | _Expression
Co-authored-by: Charles Cooper <[email protected]>
…ar fix Co-authored-by: Charles Cooper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4241 +/- ##
==========================================
+ Coverage 92.09% 92.14% +0.04%
==========================================
Files 119 121 +2
Lines 16931 17225 +294
Branches 2865 2935 +70
==========================================
+ Hits 15593 15872 +279
- Misses 919 933 +14
- Partials 419 420 +1 ☔ View full report in Codecov by Sentry. |
| from vyper.venom.passes.common_subexpression_elimination import CSE | ||
|
|
||
|
|
||
| def _check_pre_post(pre: str, post: str): |
There was a problem hiding this comment.
style thing: maybe instead of both _check_pre_post() and _check_pre_post_fn(), just have check_pre_post(pre, post, scope="basicblock"), and have a decision for which parsing function to use:
if scope == "basicblock":
parse = parse_from_basic_block
else:
assert scope == "function"
parse = parse_venom| _check_pre_post(pre, post) | ||
|
|
||
|
|
||
| def test_common_subexpression_elimination_logs_no_indepontent(): |
| _check_no_change(pre) | ||
|
|
||
|
|
||
| def test_common_subexpression_elimination_effects_3(): |
There was a problem hiding this comment.
slightly shorter names will be helpful when selecting tests manually, e.g. pytest -k test_cse_elim_effects3
vyper/venom/__init__.py
Outdated
| @@ -86,6 +87,10 @@ def _run_passes(fn: IRFunction, optimize: OptimizationLevel) -> None: | |||
| AlgebraicOptimizationPass(ac, fn).run_pass() | |||
| RemoveUnusedVariablesPass(ac, fn).run_pass() | |||
There was a problem hiding this comment.
i think this extra RemoveUnusedVariablesPass is now unnecessary
| %sum1 = add %1, 10 | ||
| %mul1 = mul %sum1, 10 | ||
| %sum2 = add 10, %1 | ||
| %mul2 = mul 10, %sum2 |
There was a problem hiding this comment.
maybe use variables here, since algebraic optimization pass moves literals to the same position
What I did
Created common subexpression elimination pass
How I did it
Created available expression analysis and common subexpressions elimination pass. The available expression analysis is done with consideration to effects which heavy inspired by multidimensional fencing.
How to verify it
Created tests
Commit message
feat[venom]: common subexpression elimination
Cute Animal Picture