Apply suggestions from code review

Co-authored-by: Derek Pierre <[email protected]>
vzotova · Aug 22, 2024 · 20b6456 · 20b6456
1 parent c3ec58f
commit 20b6456
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/deployment/params.py b/deployment/params.py
@@ -621,8 +621,8 @@ def _deploy_proxy(
 
     def upgrade(self, container: ContractContainer, proxy_address, data=b"") -> ContractInstance:
         implementation = self.deploy(container)
-        # TODO: initialize taco app implementation too
-        return self.upgradeTo(implementation, proxy_address, data)
+        # upgrade proxy to implementation
+        return self.upgradeProxyTo(implementation, proxy_address, data)
 
     def upgradeTo(
         self, implementation: ContractInstance, proxy_address, data=b""

diff --git a/scripts/lynx/upgrade_coordinator.py b/scripts/lynx/upgrade_coordinator.py
@@ -20,6 +20,8 @@ def main():
     instances = contracts_from_registry(filepath=ARTIFACTS_DIR / "lynx.json", chain_id=80002)
 
     implementation = deployer.deploy(project.Coordinator)
+    # `initializeNumberOfRituals` was used for the original upgrade, but should NOT be
+    #  used for subsequent upgrades of Coordinator
     # encoded_initializer_function = implementation.initializeNumberOfRituals.encode_input()
     encoded_initializer_function = b""
     coordinator = deployer.upgradeTo(