This repository was archived by the owner on Mar 18, 2024. It is now read-only.
Add CI build and fix conflict #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Jaegervall <[email protected]>
erikbosch
commented
Feb 23, 2024
| @@ -794,7 +794,7 @@ func main() { | |||
| vssJson := parser.String("", "vssJson", &argparse.Options{Required: false, Help: "path and name vssPathlist json file", Default: "../vsspathlist.json"}) | |||
| stateDB := parser.Selector("s", "statestorage", []string{"sqlite", "redis", "apache-iotdb", "none"}, &argparse.Options{Required: false, | |||
| Help: "Statestorage must be either sqlite, redis, apache-iotdb, or none", Default: "redis"}) | |||
| historySupport := parser.Flag("s", "history", &argparse.Options{Required: false, Help: "Support for historic data requests", Default: false}) | |||
| historySupport := parser.Flag("j", "history", &argparse.Options{Required: false, Help: "Support for historic data requests", Default: false}) | |||
There was a problem hiding this comment.
When trying to run vissv2server I got an error, which seemed to depend that we have "s" both here and on line 795 above. Seems to be a merge regression as both lines were added/changed regularly. I chnaged to "j" here to just get something unique, maybe you can propose something better.
erikbosch
commented
Feb 23, 2024
| pull_request: | ||
| branches: [ master ] | ||
| paths: | ||
| - ".github/workflows/vissv2server-build.yml" |
There was a problem hiding this comment.
This indicates the branches/files that trigger a build for a PR. Maybe more should be added. As the build is quite quick one could alternatively remove the path criteria so that it build for all PRs.
UlfBj
approved these changes
Feb 26, 2024
|
Thank you for fixing my bugs in parallel. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a simple sanity check of vissv2server. It will run on pull requests for changes in selected repos and all merges. It will just check that we can build and run to get help.
In https://github.com/w3c/automotive-viss2/pull/115/checks you can check output
Note: I got an error on duplicate "s" when running, seems like a merge regression. Did a work around but should likely be fixed in a different way