Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Use Cases and Requirements #103

Merged
merged 8 commits into from
Oct 20, 2024
Merged

Add Use Cases and Requirements #103

merged 8 commits into from
Oct 20, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Oct 12, 2024

This PR is an attempt to partially address issue #93 and #94 by adding a Use Cases and Requirements section.

/cc @jyasskin and @hadleybeeman


Preview | Diff

index.html Outdated Show resolved Hide resolved
public cryptographic keys. The [=controller document=] contains [=verification
relationships=] that explicitly permit the use of certain [=verification
methods=] for specific purposes.
relationships between an identifier that is controlled by a [=controller=] and a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another PR out there #102 that has text that conflicts with this (I think).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this text will just re-use what's in #102 eventually.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments

  1. All the use case seem to be (mostly) around identifiers, making it more explicit by the reference to the DID use cases. It does not really justify the usage in VCs. I believe such use case would be important with, if possible, a reference to the VC use cases as well
  2. We have a bunch of terms defined for referencing crypto keys, must notably Multikeys and JSONWebKeys. Something in the use cases should justify the creation of those here.

index.html Outdated
Comment on lines 313 to 323
Digital signatures, based on
<a href="https://en.wikipedia.org/wiki/Public-key_cryptography">asymmetric
cryptography</a>, can be used in [=authentication=] and [=authorization=]
schemes to make them difficult for adversaries to compromise. However,
one shortcoming of digital signatures is the challenge in disseminating
necessary information, such as public cryptographic keys, to those who need
to verify the security of a digital signature.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jandrieu can you pull this change set into #102, please? @dlongley had some good language here that we don't want to lose.

index.html Outdated Show resolved Hide resolved
schemes to make them difficult for adversaries to compromise. However,
one shortcoming of digital signatures is the challenge in disseminating
necessary information, such as public cryptographic keys, to those who need
to verify the security of a digital signature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to verify the security of a digital signature.
to verify the security of a digital signature. Another potential shortcoming is notifying the holder of a public key when it should no longer be used.

Either this or the above, since the problem is not only disseminating the public keys. It is the whole management lifecycle of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this is "another" "potential" shortcoming. I don't see any other (potential or definite) shortcomings discussed in the prior text. This suggestion needs more work before it should be considered ready to merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to make the language simpler in 7a2f27d.

@iherman
Copy link
Member

iherman commented Oct 16, 2024

The issue was discussed in a meeting on 2024-10-16

  • no resolutions were taken
View the transcript

4.1. Add Use Cases and Requirements (pr controller-document#103)

See github pull request controller-document#103.

Manu Sporny: controller doc and did document provide different solutions to ownership.
… did document has twice as many use cases as controller doc.

index.html Outdated Show resolved Hide resolved
schemes to make them difficult for adversaries to compromise. However,
one shortcoming of digital signatures is the challenge in disseminating
necessary information, such as public cryptographic keys, to those who need
to verify the security of a digital signature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this is "another" "potential" shortcoming. I don't see any other (potential or definite) shortcomings discussed in the prior text. This suggestion needs more work before it should be considered ready to merge.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member Author

msporny commented Oct 20, 2024

@iherman wrote:

All the use case seem to be (mostly) around identifiers, making it more explicit by the reference to the DID use cases. It does not really justify the usage in VCs. I believe such use case would be important with, if possible, a reference to the VC use cases as well

Done in 6ad135b.

We have a bunch of terms defined for referencing crypto keys, must notably Multikeys and JSONWebKeys. Something in the use cases should justify the creation of those here.

Done in 8dac975.

@msporny
Copy link
Member Author

msporny commented Oct 20, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 177f727 into main Oct 20, 2024
1 check passed
@msporny msporny deleted the msporny-use-cases branch October 20, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants