-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the numerical error codes to be in sync with the VCDM specification #140
base: main
Are you sure you want to change the base?
Conversation
The issue was discussed in a meeting on 2025-01-08
View the transcript3.1. Remove the numerical error codes to be in sync with the VCDM specification (pr cid#140)See github pull request cid#140. Brent Zundel: Remove numerical error codes to be in sync with the VCDM spec.
Brent Zundel: It does what it says. It removes the error codes while retaining the names of the error codes. Anyone want to say we don't want to do this, please say so, can take comments briefly, etc. if needed. Ivan Herman: Just remarking that there is a sister PR in the DI spec which does the same. It also makes the changes in the vocab definition file. These two PRs should go hand-in-hand. See github pull request vc-data-integrity#327. Manu Sporny: Yes, +1 -- we made a decision in the group to remove the error codes in the group and this is just Ivan making sure we follow that guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor but important clean up then +1. I see VCDM's problem details isn't in sync with bitstring status list either, looks like we should just loosen VCDM and then everything will be in sync and will also match the RFC requirements (advisory only), see: https://www.rfc-editor.org/rfc/rfc9457#name-title.
</li> | ||
<li> | ||
The `title` value SHOULD provide a short but specific human-readable string for | ||
The `title` value MUST be present and it SHOULD provide a short but specific human-readable string for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match what's in the other specs and not add a new MUST: https://w3c.github.io/vc-bitstring-status-list/#processing-errors
The `title` value MUST be present and it SHOULD provide a short but specific human-readable string for | |
The `title` value SHOULD provide a short but specific human-readable string for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see w3c/vc-data-integrity#327 (comment)
the error. | ||
</li> | ||
<li> | ||
The `detail` value SHOULD provide a longer human-readable string for the error. | ||
The `detail` value MUST be present and it SHOULD provide a longer human-readable string for the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match what's in the other specs and not add a new MUST: https://w3c.github.io/vc-bitstring-status-list/#processing-errors
The `detail` value MUST be present and it SHOULD provide a longer human-readable string for the error. | |
The `detail` value SHOULD provide a longer human-readable string for the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see w3c/vc-data-integrity#327 (comment)
This is the sister PR to w3c/vc-data-integrity#327 removing the numerical codes from the error entries. See w3c/vc-data-integrity#327 for further description of the changes.
Preview | Diff