-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify terminology for triples #158
base: main
Are you sure you want to change the base?
Conversation
redefine "RDF triple" so that "triple term" and "asserted triple" are two different roles for triples, rather than objects of different nature. This also induced some changes in Section 1 "Introduction", but the rest of the text works well with this change.
@franconi @pfps @doerthe I took the initiative to redefine "appears in" in RDF-concepts, while defining triple terms. https://pr-preview.s3.amazonaws.com/w3c/rdf-concepts/pull/158.html#dfn-appear There is one change compared to the one that his currently in RDF-Semantics: WDYT? |
I'd use "inductively" instead of "recursively". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @hartig 's suggestions
Co-authored-by: Olaf Hartig <[email protected]>
This was partially done: Section 1.8 now states that "An RDF triple encodes a proposition" (it used to say "statement"). I didn't introduce the term "fact", partly because I was under the impression that it was still disputed, partly because I didn't find any natural place to introduce it. |
"fact" would work for me. "facts" can be disputed etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
I will live with "facts". It still doesn't make me happy, and I have hopes that someone will have a brilliant better idea, some day. But I won't block on that basis. |
The new "triples" section is doing a lot of work. Because triples-as-objects are new to RDF 1.2, the all-in-one triples section
There could still be a section on "Triple terms", starting """ then that section includes term equality for triple terms (#154) and the second ("rdf:reifies") notes. Should there be a subsection "Graphs"? At the moment there is intro one line. A graph subsection would include "set of nodes" and "appears" and "graph comparison". The "3. Graphs" text would be introducing the section, and maybe the place define "RDF term". |
@afs I like your suggestions, but do we agree that they should not hold this PR? (given that you have approved the PR, I assume we agree on this, but just checking) |
I am fine with the changes, only wonder whether that means that we need to extend the definition for symmetric RDF as we use it in RDF semantics. Or should we do that here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afs I like your suggestions, but do we agree that they should not hold this PR? (given that you have approved the PR, I assume we agree on this, but just checking)
That was before I saw the impact of triple term equality - part of what makes the "triples" section bigger.
I'm not blocking this merging. If it is only as an intermediate, and removes the "triple term" section, which goes back in again, it might be easier to sketch the final form here first.
We should take that discussion to a separate issue. At https://www.w3.org/TR/rdf12-semantics/#notation talks about generalized RDF. |
In my opinion the definitions of symmetric/generalized RDF do not need to be changed. They still "work" with the new perspective on triples/triple terms/asserted triples. |
This also creates a new 'RDF Terms' section, preceding the IRIs, Literals, Blank nodes and Triple terms sections, containing some general definitions about terms.
Fair enough. I just pushed a change, which is exclusively moving text, without changing it (with one exception, see below). The text that was before in the 'Triples' section is now moved as follows:
The only change in the text is in the note about recursive triples not allowing cycles: it was talking about "triple terms", now talks about "triples" (in fact, I should have done this change before). Re-requesting reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with moving things around as done in the last commit.
I have only two minor issues that are easily fixed.
I agree, my concern was different: we defined the notion of "appears in" to deal with the entailment patterns which assume symmetric RDF. Now, after we moved that definition to RDF concepts, it does not cover the case that triple terms could occur in subject position. My question was now: how do we best deal with that detail? |
Co-authored-by: Olaf Hartig <[email protected]>
oh! Now I get it. 🫤 |
In fact, another option is to make the definition of "appears" more general (which is how it is defined in RDF-Semantics), i.e. replacing
with
This is maybe a little less legible, but generalizes nicely to symmetric and generalized RDF. |
I like that option. |
I am happy with that option as well. |
Done :) (in the commit just below) |
redefine "RDF triple" so that "triple term" and "asserted triple" are two different roles for triples,
rather than objects of different nature, per my action w3c/rdf-star-wg#145.
This also induced some changes in Section 1 "Introduction", but the rest of the text works well with this change.
Preview | Diff