-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that RP can use its own credentials even if extension not specified #272
base: main
Are you sure you want to change the base?
Changes from all commits
cb9c46a
72b71ed
5b0d973
2da2785
3782d53
c7f1466
c603f01
83ec338
540f44f
95a6447
5d8d4f3
273cde6
b115212
9ddc37c
a6ae5d9
ac8496d
4b258c5
8c8feed
f084af4
16d765d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -206,7 +206,7 @@ This limitation motivates the following Secure Payment Confirmation behavior: | |
|
||
1. SPC supports cross-origin registration from an iframe in a third-party | ||
context. For instance, this registration might take place following some | ||
other identity and verification (<abbr>ID&V</abbr>) flow (e.g., SMS OTP). | ||
other identity and verification (<abbr>ID and V</abbr>) flow (e.g., SMS OTP). | ||
|
||
* See <a href="https://github.com/w3c/webauthn/issues/1656">discussion | ||
on WebAuthn issue 1656</a>. | ||
|
@@ -798,10 +798,15 @@ input {{SecurePaymentConfirmationRequest}} |data|, are: | |
1. For each |id| in |data|["{{SecurePaymentConfirmationRequest/credentialIds}}"]: | ||
|
||
1. Run the [=steps to silently determine if a credential is available for | ||
the current device=] and the [=steps to silently determine if a | ||
the current device=], passing in | ||
|data|["{{SecurePaymentConfirmationRequest/rpId}}"] and |id|. | ||
If the result is `false`, remove |id| from | ||
|data|["{{SecurePaymentConfirmationRequest/credentialIds}}"]. | ||
1. If the |data|["{{SecurePaymentConfirmationRequest/rpId}}"] is | ||
not in the current origin, run the [=steps to silently determine if a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, so we don't just say things like "is not in the current origin" in specs 🤣 . We try to make them a bit more like code. I think this should be: At the top of this method, change to:
(adding 'request', to get it in scope for looking up. This is a bit hand-wavy as Payment Request doesn't currently pass it in to the 'Steps to check if a payment can be made', but we can fix that later, not a big deal I think) Then:
|
||
credential is SPC-enabled=], passing in | ||
|data|["{{SecurePaymentConfirmationRequest/rpId}}"] and |id|. If the | ||
result of either of these is `false`, remove |id| from | ||
result is `false`, remove |id| from | ||
|data|["{{SecurePaymentConfirmationRequest/credentialIds}}"]. | ||
|
||
1. If |data|["{{SecurePaymentConfirmationRequest/credentialIds}}"] is now empty, | ||
|
@@ -1666,4 +1671,3 @@ This section adds the below-listed [=extension identifier=] to the IANA "WebAuth | |
- Specification Document: Section [[#sctn-payment-extension-registration]] of this specification | ||
- Change Controller: [W3C Web Payments Working Group](https://www.w3.org/groups/wg/payments) | ||
- Notes: Registration follows [3 May 2023 discussion](https://www.w3.org/2023/05/03-webauthn-minutes#t01) with the Web Authentication Working Group. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to spell out ID&V every time? Perhaps it could just go into https://w3c.github.io/secure-payment-confirmation/#sctn-terminology if needed (or be defined only the first time its used).