Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#466 #629

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#466 #629

wants to merge 2 commits into from

Conversation

jspellman
Copy link
Contributor

No description provided.

bruce-usab
bruce-usab previously approved these changes May 17, 2022
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! I think there may be a verb mismatch though.

Current:

The Guidelines motivate organizations to go beyond minimal accessibility requirements by structuring WCAG 3 to encourage organizations which demonstrate a greater effort to improve accessibility.

Proposed:

The Guidelines motivate organizations to go beyond minimal accessibility requirements by structuring WCAG 3 to provide encouragement to organizations which demonstrate a greater effort to improve accessibility.

I am not clear if which demonstrate a greater effort to improve accessibility applies to WCAG3 (itself) or to the organization which use WCAG3 (to guide the organization's efforts).

@jspellman
Copy link
Contributor Author

I like your proposal and will fix the PR. Please don't approve it, though. It needs to go to survey before it is approved. We are working on the process, so it's a little confusing.

@bruce-usab
Copy link
Contributor

bruce-usab commented May 17, 2022

It needs to go to survey before it is approved. We are working on the process, so it's a little confusing.

I had/have assumed the submit review feature ( comment / approve / request changes ) is more of a 0/+1/-1 feedback and not really related to AGWG approval and especially not PR approval. But (as you note) it is a little confusing, so I will stop doing that until there is clarification one way or the other. GitHub comment threads seem to be working pretty well, regardless of the approve/comment/disapprove feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants