Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCS Context Injection #61

Merged
merged 3 commits into from
Jun 9, 2024
Merged

JCS Context Injection #61

merged 3 commits into from
Jun 9, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented May 22, 2024 •
edited by pr-preview bot
Loading

This PR addresses issue w3c/vc-data-integrity#225 to properly handle @context injection issues that could arise with JCS. Note that this also applies to @context issues that could arise with proof sets/chains with JCS. This PR contains normative changes to the Create Proof (ecdsa-jcs-2019) and Verify Proof (ecdsa-jcs-2019) algorithms.

This PR does NOT include informative text such as:

  1. Explanation of why these steps are necessary and sufficient. Such informative text is present in the discussions of issue Context injection can lead to interference between proofs on a document, breaking verification of jcs-based proofs vc-data-integrity#225 and could be extracted and included somewhere in the document. Thoughts?
  2. Updates to the current ecdsa-jcs-2019 test vectors in the specification. Will be updated after this PR is reviewed.

Preview | Diff

@Wind4Greg Wind4Greg requested review from dlongley and TallTed May 22, 2024 22:48
This was referenced May 23, 2024
Merged
Merged
@msporny msporny mentioned this pull request Jun 9, 2024
Closed
@msporny msporny added normative This item is a normative change. CR1 This item was processed during the first Candidate Recommendation phase. labels Jun 9, 2024
@msporny
Copy link
Member

msporny commented Jun 9, 2024

Normative, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 5a2e764 into w3c:main Jun 9, 2024
2 checks passed
This was referenced Jun 9, 2024
Open
Closed
@Wind4Greg Wind4Greg deleted the jcs-injection branch December 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@dlongley dlongley dlongley approved these changes

@TallTed TallTed TallTed approved these changes

@martyr280 martyr280 Awaiting requested review from martyr280 martyr280 is a code owner

@seabass-labrax seabass-labrax Awaiting requested review from seabass-labrax

Assignees
No one assigned
Labels
CR1 This item was processed during the first Candidate Recommendation phase. normative This item is a normative change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wind4Greg @msporny @dlongley @TallTed