corrections missed in #64 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete now-errant line
- fix "ensure" phrasing — note: this sentence may need further work, as it's not clear whether confirming `an array of five elements` is sufficient to populate `the five elements` --
```
Initialize |components| to an array that is the result of CBOR-decoding the
bytes that follow the three-byte ECDSA-SD base proof header. Ensure the result
is an array of five elements.
</li>
<li>
Return an object with properties set to the five elements, using the names
`baseSignature`, `publicKey`, `hmacKey`, `signatures`, and `mandatoryPointers`,
respectively.
```
TallTed
requested review from
msporny,
martyr280,
Wind4Greg and
seabass-labrax
as code owners
dlongley
approved these changes
Jul 1, 2024
msporny
approved these changes
Jul 10, 2024
|
Editorial, multiple reviews, no changes requested, no objections, merging. |
msporny
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete now-errant line
fix "ensure" phrasing — note: this sentence may need further work, as it's not clear whether confirming
an array of five elementsis sufficient to ensure proper population ofthe five [named] elements--Preview | Diff